Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(root): add support for node 18 #3758

Merged
merged 9 commits into from
Jul 26, 2023
Merged

Conversation

zahin-mohammad
Copy link
Contributor

@zahin-mohammad zahin-mohammad commented Jul 25, 2023

Description

Please include a summary of your proposed changes and which issue is being addressed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR adds support for node 18 and updates CI to add node 18 to the test matrix.

Issue Number

TICKET: WP-338

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Existing tests exist.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @types/[email protected], [email protected]

@zahin-mohammad zahin-mohammad changed the title feat(root): add node 18 to engines and CI feat(root): add support for node 18 Jul 25, 2023
@zahin-mohammad zahin-mohammad force-pushed the WP-338/support-node-18 branch 7 times, most recently from c95a5f4 to 9bcde04 Compare July 26, 2023 12:55
@zahin-mohammad zahin-mohammad marked this pull request as ready for review July 26, 2023 15:13
@zahin-mohammad zahin-mohammad requested review from a team as code owners July 26, 2023 15:13
@zahin-mohammad zahin-mohammad merged commit fd97cf4 into master Jul 26, 2023
7 checks passed
@zahin-mohammad zahin-mohammad deleted the WP-338/support-node-18 branch July 26, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants